lincomatic / open_evse

Firmware for Open EVSE
GNU General Public License v3.0
114 stars 163 forks source link

Session elapsed time should be consistent with session energy #79

Closed glynhudson closed 6 years ago

glynhudson commented 6 years ago

I'm running latest dev version with the update to reset the session energy when the car in un-plugged even in the unit is in 'sleep' state (charging timer active). This is working very well.

However I have noticed another issue: the time elapsed resets each time the evse is paused then resumed. IMO the session timer should be consistent with session energy. I would consider pausing then resuming a charge (without un-plugging the car) the be the same charging session therefore the time elapsed should not reset. See illustration video:

https://youtu.be/R8hdGba5Ygw

lincomatic commented 6 years ago

I agree.

On Dec 1, 2017, at 2:53 AM, Glyn Hudson notifications@github.com<mailto:notifications@github.com> wrote:

I'm running latest dev version with the update to reset the session energy when the car in un-plugged even in the unit is in 'sleep' state (charging timer active). This is working very well.

However I have noticed another issue: the time elapsed resets each time the evse is paused then resumed. IMO the session timer should be consistent with session energy. I would consider pausing then resuming a charge (without un-plugging the car) the be the same charging session therefore the time elapsed should not reset. See illustration video:

https://youtu.be/R8hdGba5Ygw

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/lincomatic/open_evse/issues/79, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABWzagO5I_TnbiwyhF-qiCFOSIsLti55ks5s73kWgaJpZM4Qx1dq.

lincomatic commented 6 years ago

OK, it's fixed. We now reset the session counter only when the EV is reconnected after it's been disconnected, so it's consistent w/ the energy counter

https://github.com/lincomatic/open_evse/commit/ee0f1b3f49d6884936c4c267d97b2f340dbfea03

Thanks for bringing this to my attention.

glynhudson commented 6 years ago

Fantastic, thanks :+1: