search

lincomatic / open_evse

Firmware for Open EVSE
GNU General Public License v3.0
114 stars 163 forks source link

PP_TABLE_TESLA? #86

Closed glynhudson closed 6 years ago

glynhudson commented 6 years ago

Sorry, this is a question rather than an issue.

It's fantastic that openevse has implemented PP_AUTO_AMPACITY for non-tethered EU type-2 socket units. Nice work 👍

The PP_TABLE_IEC resistor and current values all match the EN 61851:1 spec. My question is why the need for PP_TABLE_TESLA

https://github.com/openenergymonitor/open_evse/blob/master/firmware/open_evse/AutoCurrentCapacityController.cpp#L30

Tesla's charge using standard EV cables in the EU which have the same PP > GND resistor in the type-2 plug to identify the cables current rating. Why the need for a separate lookup table? I can't see this documented anywhere.

Thanks.

lincomatic commented 6 years ago

I don't know where the PP_TABLE_TESLA values came from. Perhaps they were from an older model that wasn't IEC compliant

glynhudson commented 6 years ago

I guess this must be it. I'm pretty sure that all Teslas (at least in UK/EU) are IEC compliant. Can you remember who contributed this code?

lincomatic commented 6 years ago

They came from the person who requested the PP support to be implemented. He has since stopped using it, himself. I've removed it to prevent confusion.

https://github.com/lincomatic/open_evse/commit/7f772c469f77199e35cf271f13c1ec9448ed69e4