search

lindahua / MixtureModels.jl

A Julia package for probabilistic mixture models
MIT License
13 stars 5 forks source link

AbstractModelEstimator #2

Open nfoti opened 11 years ago

nfoti commented 11 years ago

I like how you used the MLE_Estimator and MAP_Estimator types to select the appropriate function for fit. I think this should be moved to the Distributions package as it would be useful for other packages and then they would only have to depend on Distributions and not MixtureModels as well just for the estimator types, not to mention the fact that Distributions seems like a reasonable place for the estimator types since that's were all the fit* functions are.

Sorry for the massive run-on sentence.

lindahua commented 11 years ago

This package hasn't been updated while the Distributions.jl has undergone substantial changes. Yes, it is time to revisit the API here.

lindahua commented 11 years ago

I open an issue for this in the Distributions package: https://github.com/JuliaStats/Distributions.jl/issues/137.