search

linde12 / kod

terminal text editor written in Go, using xi-editor as backend
MIT License
315 stars 20 forks source link

linecache invalidation is not up to date with xi-core #7

Closed linde12 closed 6 years ago

linde12 commented 6 years ago

The core introduced a breaking change and i haven't had the time to update kod yet.

I think this can be fixed somewhere in the ApplyUpdate method in editor/linecache.go

There are a few editors which have implemented this already. I believe xi-tui(rust) amongst other should work with the latest version. There is also some documentation about this in the xi-editor project.

sjoshid commented 6 years ago

Let me try to fix this. I see some changes that need to be applied to ApplyUpdate.

linde12 commented 6 years ago

@sjoshid Sure thing! I haven't looked into exactly what's causing the rendering to go bad, but i'm pretty sure it has to do with ApplyUpdate as well. Tell me if you need anything.

sjoshid commented 6 years ago

@linde12 I assume this is the issue referring to.

linde12 commented 6 years ago

Yes @sjoshid, exactly

sjoshid commented 6 years ago

Great. I have already fixed it. Doing some final testing. I'll commit probably after I get home from work.

linde12 commented 6 years ago

Awesome! Maybe soon we'll back to having the editor be compatible with xi-editor@master :-)

linde12 commented 6 years ago

I think we can close this thanks to #11 but there are still problems with the editor. Especially how the last lines and the line numbers behave. I will make separate issues.