lindegroup / autopkgr

AutoPkgr is a free Mac app that makes it easy to install and configure AutoPkg.
http://www.lindegroup.com/autopkgr
Apache License 2.0
532 stars 51 forks source link

GitHub URL being added to "Update This Repo Only" in 1.5.6 #666

Closed Lotusshaney closed 3 years ago

Lotusshaney commented 3 years ago

Trying to update a single repo by right clicking and selecting "Update This Repo Only" results in https://github.com/ being added to the local URL and errors out.

See Attached picture Screenshot 2021-03-02 at 15 29 54

This happens with all repos

jazzace commented 3 years ago

Can confirm. I selected 2 repos that needed updating (🟡) and used the contextual menu to "Update Selected Repos". I received an error message for both of the kind shown in the screenshot above. I then went to Terminal and tried to update them from there:

% autopkg repo-update jazzace-recipes homebysix-recipes
ERROR: Can't find an installed repo for https://github.com/autopkg/jazzace-recipes
Attempting git pull for /Users/tech/Library/AutoPkg/RecipeRepos/com.github.autopkg.homebysix-recipes...
Updating 451b3e7..ae5053b
Fast-forward
 Zscaler/Zscaler.munki.recipe | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

The interesting thing here is that the second one, which threw an error previously, was correctly updated. So I ran the repo-update command again for the problem repo:

% autopkg repo-update jazzace-recipes                  
ERROR: Can't find an installed repo for https://github.com/autopkg/jazzace-recipes

So I then tried to delete and re-add:

% autopkg repo-delete jazzace-recipes && autopkg repo-add jazzace-recipes
ERROR: Can't find an installed repo for https://github.com/autopkg/jazzace-recipes
Attempting git pull for /Users/tech/Library/AutoPkg/RecipeRepos/com.github.autopkg.jazzace-recipes...
Updating e975fda..c8d8a0f
Fast-forward
 Zoom/Zoom-ForIT.pkg.recipe | 83 ++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 83 insertions(+)
 create mode 100644 Zoom/Zoom-ForIT.pkg.recipe

Updated search path:
[…]

It was unsuccessful in deleting it, but the repo-add verb still saw the local copy and simply updated the repo. AutoPkgr then correctly confirmed that the local copy of the repos are up to date.

I did a further test on a repo that did not need updating (and for some reason did not have a 🟢 or any status indicator at all, but that's a separate bug report) and it threw the same error, but checking it at the command line with repo-update reported Already up-to-date, so it does not seem to do damage in that instance.

apizz commented 3 years ago

+1

shawnhonsberger commented 3 years ago

I'm unable to reproduce this. Are you running AutoPkg 2.3?

apizz commented 3 years ago

Yes for me

jazzace commented 3 years ago

I am using AutoPkg 2.3 as well. I had an un-updated copy on another machine, so here's what I found: 2.2 + 1.5.5 = success 2.3 + 1.5.5 = fail And my previous report was: 2.3 + 1.5.6 = fail

So it looks like the issue is caused by a change in AutoPkg 2.3, not a change in AutoPkgr 1.5.6.

shawnhonsberger commented 3 years ago

Interesting, thanks for the follow up @apizz and @jazzace.

Lotusshaney commented 3 years ago

Have checked with AutoPkg 2.3.1 and this appears to fix this problem

shawnhonsberger commented 3 years ago

Thanks @Lotusshaney!