search

lindell / multi-gitter

Update multiple repositories in with one command
Apache License 2.0
819 stars 64 forks source link

Feature request: Draft PR -> Ready For Review #455

Closed taylorperkins closed 1 month ago

taylorperkins commented 5 months ago

The feature request When an existing PR exists and the --draft flag is not present in the run command (or perhaps this needs to be a new command?), update the existing PR from "Draft" to "Ready For Review"

My use case The --draft flag on the run command is a great feature, especially when you do not want to bug other teammates before a change has gone through CI/CD stuff. However, I am not sure of an existing way for multi-gitter to update the state of the draft PRs to "Ready For Review", specifically for PRs that have a good status.

Implementation

lindell commented 5 months ago

I think this PR #368 might partly add this feature. But with the side-effect or re-running the script. It might be a good idea to enable just the updating as well.

Etienne-M commented 5 months ago

I think this PR https://github.com/lindell/multi-gitter/pull/368 might partly add this feature. But with the side-effect or re-running the script. It might be a good idea to enable just the updating as well.

@lindell Is there any interest in supporting this in the future? I could take a look at it if there's appetite to include this feature in the repo. Did you think of what the CLI commands/options would look like?

lindell commented 4 months ago

@Etienne-M I would be interested in merging a PR to add this support.

After checking #368 again. It seems that draft was missed from that update, but should be a 1 line PR to add it since it's already sent with the scm.NewPullRequest struct.

But after that, we should add a new command, probably multi-gitter update, that basically only calls into the new versionController.UpdatePullRequest function added in #368 for each PR.

github-actions[bot] commented 2 days ago

Included in release v0.52.1 🎉