search

lindenb / jvarkit

Java utilities for Bioinformatics
https://jvarkit.readthedocs.io/
Other
482 stars 133 forks source link

Making contained optional #4

Closed johandahlberg closed 10 years ago

johandahlberg commented 10 years ago

I've come across a use case in out lab where we need optional to be set to false, so I've made it possible to set this as an option. Have a look at it and say if you think it's reasonable or not to include it in the main code base.

lindenb commented 10 years ago

Thank you.

However, I didn't like this kind-of "double-negation". I sightly changed the code: https://github.com/lindenb/jvarkit/commit/ffcdd7bf241c12030cc6b67fa912429a0c9b5e31

johandahlberg commented 10 years ago

No problem. I wanted to change as little as possible, that's why I went with the double negation solution. But yours is no doubt a nicer solutions. Cheers.