search

lindenlab / caddy-s3-proxy

s3 proxy plugin for caddy
Apache License 2.0
72 stars 22 forks source link

Adds use_acceleration option support for S3 (+ s3 force_path_styles) #30

Closed christoph-kluge closed 3 years ago

christoph-kluge commented 3 years ago

Addresses #29

rayjlinden commented 3 years ago

I am thinking force_path_style should default to true. I think a good many folks will try this with localstack and if that is not the default then its a "custom" thing they have to learn right away. It being the default will often work just fine on AWS for most use cases. Just want it to be as simple as possible for a new user to get going.

Thoughts?

christoph-kluge commented 3 years ago

The only one I could think of is the upcoming deprecation of path-style based urls:

https://aws.amazon.com/blogs/aws/amazon-s3-path-deprecation-plan-the-rest-of-the-story/

I guess that this is the reason why there is the "force" option.

rayjlinden commented 3 years ago

That's a pretty good reason. I guess it makes it consistent with all other aws sdks as well...