Open AstraLuma opened 3 weeks ago
The changes in this pull request primarily involve the renaming of the S3Proxy
type to resolved_proxy
and the introduction of a new struct that encapsulates configuration values. Method signatures across the caddys3proxy
package have been updated to reflect this new type. Additionally, a new method, ResolveValues
, has been added to facilitate the resolution of configuration variables. The overall control flow has been adjusted to utilize the new struct while maintaining existing functionality.
Files | Change Summary |
---|---|
browse.go, s3proxy.go | - Renamed S3Proxy to resolved_proxy and updated related method signatures (ConstructListObjInput , MakePageObj , etc.).- Introduced a new struct resolved_proxy for configuration resolution.- Added ResolveValues method to S3Proxy for variable substitution.- Updated handler methods to accept resolved_proxy instead of S3Proxy . |
browse_test.go | - Updated test cases to instantiate resolved_proxy instead of S3Proxy , ensuring tests reflect the new type. |
Objective | Addressed | Explanation |
---|---|---|
Host variable not replaced on certain requests (#52) | ❓ | The changes focus on restructuring and renaming but do not explicitly address the issue of host variable replacement. Further validation is needed to confirm if the issue is resolved. |
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
CodeRabbit is making enough noise that i'm just going to ignore it unless a person says otherwise.
Adds variable support to as many configs as is feasible, without messing with initialization order.
Fixes #52
Replaces #68
Summary by CodeRabbit
New Features
resolved_proxy
, to enhance configuration value management during provisioning.ResolveValues
method for variable substitution in configuration fields.Improvements
resolved_proxy
type, ensuring better handling of configuration values.Bug Fixes