search

lindig / polly

OCaml bindings for Linux epoll(2)
MIT License
9 stars 4 forks source link

make lint #8

Open craff opened 11 months ago

craff commented 11 months ago

make lint is not configured in the same way as lint in the worflow ? on my machine, make lint reports no error while the workflow fails with the same code.

craff commented 11 months ago

needed quite a lot of time to make lint happy because of this.

lindig commented 11 months ago

I agree that the CI workflow is quite picky. I merged it recently from a PR and struggled with it, too. It has access to several OCaml releases, unlike the local installation. I am a bit torn whether to make the listing less struct. On the other hand, it is likely to help with submissions to Opam.

craff commented 11 months ago

I make lint would just do the same check, that will be ok for me.

Le 5 août 2023 05:55:59 GMT-10:00, Christian Lindig @.***> a écrit :

I agree that the CI workflow is quite picky. I merged it recently from a PR and struggled with it, too. It has access to several OCaml releases, unlike the local installation. I am a bit torn whether to make the listing less struct. On the other hand, it is likely to help with submissions to Opam.

-- Reply to this email directly or view it on GitHub: https://github.com/lindig/polly/issues/8#issuecomment-1666540298 You are receiving this because you authored the thread.

Message ID: @.***>

edwintorok commented 11 months ago

I think 'dune build @fmt' is missing from 'make lint' (there is an indent target in the Makefile though)

craff commented 11 months ago

in fact, make lint + make format is ok. Maybe make test could depend upon lint and format ?