lindy-labs / opus_contracts

Opus Source Code
https://opus.money
Other
0 stars 0 forks source link

tests: migrate event tests #508

Closed bllu404 closed 11 months ago

bllu404 commented 11 months ago

The following event checks were omitted:

  1. Section starting at line 130 in test_absorber commented out due to Failed setting up runner error
  2. Sections starting at lines 786 and 857 in test_absorber were commented out due to Foundry not yet having support for checking which events weren't emitted. This should still be possible using Foundry's current API but it's a lot more complicated.
  3. Sections starting at lines 1468, 1977, 2490 in test_purger were commented out due to foundry not having support for pop_event_with_indexed_keys-like functionality. Again this should probably be possible but a lot more complicated.

IMO it's worth waiting for foundry to develop some of these features before doing it ourselves as these are not critical parts of the tests. What do you guys think?