search

lindy-labs / opus_contracts

Opus Source Code
https://opus.money
Other
0 stars 0 forks source link

chore: migrate deployment script to sncast #575

Closed tserg closed 7 months ago

tserg commented 7 months ago

See updated README for the instructions on launching devnet and running the deploy command.

Notes

tserg commented 7 months ago

Really cool how smooth and fast the deployment to devnet is.

  1. Just curious, have you tried deploying to Sepolia (maybe even just 1 contract)?

Not yet, should I give it a go?

  1. Starknet Foundry version in .tool-versions needs updating.

It is a bit tricky, because the main tests will fail on v0.21.0 snfoundry due to the limit of 1,000 events, which in turn originates from blockifier. I think we can do this in a separate PR and fix the failing tests there. What do you think?

  1. Instead of printing out the contract addresses inline as they deploy, can you please print out a summary table at the end of the deploy script? It's easier to navigate.

Sounds good!

milancermak commented 7 months ago

should I give it a go?

If you can, yeah, go for it. I can also pick it up tomorrow.

It is a bit tricky, because the main tests will fail on v0.21.0 snfoundry due to the limit of 1,000 events, which in turn originates from blockifier. I think we can do this in a separate PR and fix the failing tests there. What do you think?

Aaaaah, I forgot about that. Agreed on fixing it in a separate PR, which you already started 👑

milancermak commented 7 months ago

Ah. If I use starknet-foundry 0.21.0 it works. 0.19.0 fails.