search

lindy-labs / opus_contracts

Opus Source Code
https://opus.money
Other
0 stars 0 forks source link

chore: bump snfoundry #581

Closed tserg closed 6 months ago

tserg commented 6 months ago

This PR bumps snfoundry and sncast to 0.23.0.

While running scarb update, I noticed that the Scarb.lock files in scripts/deployment and scripts/simulation were not updated despite bumping sncast to 0.23.0 and scarb update in their respective directories. I think their lockfiles are now ignored since all their dependencies are inherited from the scripts workspace, and hence I have deleted them.

milancermak commented 6 months ago

Lock files not updating in sub-packages seems like a Scarb bug to me, if you care to investigate/report to the SWM team.

tserg commented 6 months ago

Lock files not updating in sub-packages seems like a Scarb bug to me, if you care to investigate/report to the SWM team.

I have checked with the Scarb team in Discord. I will proceed to merge first.

tserg commented 6 months ago

Lock files not updating in sub-packages seems like a Scarb bug to me, if you care to investigate/report to the SWM team.

To close the loop on this, the Scarb team clarified on Discord that "scarb will created only one lock file for the whole workspace, no matter when you run it. It will be created in the workspace root besides the workspace manifest."

Hence, this is expected behaviour.