lindylearn / unclutter

A modern reader mode and article library for your browser.
https://unclutter.lindylearn.io
GNU Affero General Public License v3.0
1.24k stars 54 forks source link

Orion browser support #569

Open phgn0 opened 1 year ago

phgn0 commented 1 year ago

Installing Unclutter in the Orion browser (https://browser.kagi.com/) doesn't work for the Chrome version, and the Firefox one doesn't unclutter articles.

We should look into this.

vprelovac commented 1 year ago

It appears that Unclutter is using a regular expression that does not work in WebKit so we would need to support it excplicitly.

dinodev90 commented 1 year ago

We are getting regex error _syntaxerror: Invalid regular expression: invalid group specifier name_ in /common/library-components/dist/common/search.js for below line-

let tokens = text.match(/(?<=\s+|^)["'‘“'"[({⟨]?(.*?[.?!])(\s[.?!])*["'’”'"\])}⟩]?(?=\s+|$)|(?<=\s+|^)\S(.*?[.?!])(\s[.?!])*(?=\s+|$)/g);

Please have a way to make this regex compatible with WebKit

Carl-ki commented 1 year ago

I will donate $20 to any fix for this issue.

vprelovac commented 1 year ago

Unclutter works in Orion now, this issue can be closed.