search

line / armeria

Your go-to microservice framework for any situation, from the creator of Netty et al. You can build any type of microservice leveraging your favorite technologies, including gRPC, Thrift, Kotlin, Retrofit, Reactive Streams, Spring Boot and Dropwizard.
https://armeria.dev
Apache License 2.0
4.82k stars 920 forks source link

Tracing decorators could allow more customization of Span. #1332

Open anuraaga opened 6 years ago

anuraaga commented 6 years ago

I think right now, it's not easy to customize a span. While thinking about https://github.com/openzipkin/zipkin/issues/2167 I realized that being able to set Span.remoteServiceName based on the host would be convenient. I think we could add a customizer given the ctx and Span.

Of course, a delegate decorator could do this already but it's pretty cumbersome.

anuraaga commented 6 years ago

/cc @adriancole

codefromthecrypt commented 6 years ago

agreed.. we have some practice in brave both for normal http and grpc. I think it is called Parser when we are scraping something for tags