JMX integration plan? - Githubissues

line / armeria

Your go-to microservice framework for any situation, from the creator of Netty et al. You can build any type of microservice leveraging your favorite technologies, including gRPC, Thrift, Kotlin, Retrofit, Reactive Streams, Spring Boot and Dropwizard.

https://armeria.dev

Apache License 2.0

4.83k stars 918 forks source link

JMX integration plan? #16

Closed freesoft closed 6 years ago

freesoft commented 8 years ago

I saw armeria LINE_DevDay2015 PDF mentioning the necessary of JMX integration for the library. Do you guys have any follow up on this? Wondering if you guys want to build JMX stuff into library from the scratch or want to use existing JMX libraries like Netflix Servo or Dropwizard Metrics?

blmarket commented 8 years ago

I'm trying to integrate armeria with Dropwizard Metrics, I'll post update here.

trustin commented 8 years ago

@blmarket Thanks, Heon! :-)

freesoft commented 8 years ago

I think you guys already talked each other in person, but what metrics is going to be necessary here? success fail # or ratio per given time window? # of timeout?

blmarket commented 8 years ago

Current target is success/failure count as well as response time histogram. (xx% percentile) please leave a note if need more.

trustin commented 8 years ago

You might want to take a look into what Finagle has done.

https://twitter.github.io/finagle/guide/Metrics.html

trustin commented 8 years ago

Seems like we have a pretty solid metric collecting decorator implementation now. What would be the next step? What are in my mind are:

Export JVM and O/S stats via Dropwizard Metrics.
- Use existing exporter implementation if someone implemented it already.
Integrate all metrics into DocService.
Export Dropwizard Metrics registry via JMX.

trustin commented 6 years ago

This has been basically resolved since we added metric support using Micrometer, which provides JMX registry: https://javadoc.io/doc/io.micrometer/micrometer-registry-jmx/1.0.0-rc.7