Closed minwoox closed 3 weeks ago
I didn't add a currentAttempt
tag to the metric because the important aspect on the metric side is not the currentAttempt
, but the totalAttempt
, which we already handle. However, please let me know if you have a different opinion.
Motivation: Currently, it is difficult to distinguish from a log if a request is being retried when a
LoggingClient
is added before aRetryingClient
. Including the current attempt number in logs will help resolve this issue.Modifications:
RequestLog
.Result:
RequestLog
now includes the current attempt number if the request is created from a retrying client.ClientRequestContext.newDerivedContext(RequestId,HttpRequest,RpcRequest,Endpoint)
is deprecated.ClientRequestContext.newDerivedContext(RequestId,HttpRequest,RpcRequest,Endpoint,int)
.