Fix a bug that `FallbackService` doesn't respect `Flags.allowSemicolonInPathComponent()` - Githubissues

line / armeria

Your go-to microservice framework for any situation, from the creator of Netty et al. You can build any type of microservice leveraging your favorite technologies, including gRPC, Thrift, Kotlin, Retrofit, Reactive Streams, Spring Boot and Dropwizard.

https://armeria.dev

Apache License 2.0

4.73k stars 899 forks source link

Fix a bug that `FallbackService` doesn't respect `Flags.allowSemicolonInPathComponent()` #5727

Closed minwoox closed 1 month ago

minwoox commented 1 month ago

Motivation: FallbackService creates a new RoutingContext with appending / to the old path to check if a service is bound to the path. https://github.com/line/armeria/blob/94151152f27df5c8ad61d7d3b840fc47ca2c0161/core/src/main/java/com/linecorp/armeria/server/FallbackService.java#L72 However, it doesn't respect Flags.allowSemicolonInPathComponent() when creating the new RoutingContext which results in an exception.

Modification:

Respect Flags.allowSemicolonInPathComponent() in RoutingContext.withPath().

Result:

FallbackService doesn't raise an exception anymore when Flags.allowSemicolonInPathComponent() is true and the request path contains a semicolon.

github-actions[bot] commented 1 month ago

🔍 Build Scan® (commit: e64e00cdecd7f76e0f16b306c7f3c8c5aed370fb)

Job name	Status	Build Scan®