line / armeria

Your go-to microservice framework for any situation, from the creator of Netty et al. You can build any type of microservice leveraging your favorite technologies, including gRPC, Thrift, Kotlin, Retrofit, Reactive Streams, Spring Boot and Dropwizard.
https://armeria.dev
Apache License 2.0
4.73k stars 899 forks source link

Fix `CorsServerErrorHandler` to work with dynamic `CorsService` #5739

Closed ikhoon closed 4 weeks ago

ikhoon commented 4 weeks ago

Motivation:

This PR is follow-up of https://github.com/line/armeria/pull/5632#discussion_r1595038769 and #5670 that ctx.findService() should be used to find CorsService added with route decorators.

Modifications:

Result:

CorsServerErrorHandler now correctly handles response exceptions even if CorsService is added as a route decorator. (Not need to be mentioned in the release notes)

github-actions[bot] commented 4 weeks ago

🔍 Build Scan® (commit: f280917a87b244f81129d2a2ddb29c1f779118c1)

Job name Status Build Scan®
build-windows-latest-jdk-21 https://ge.armeria.dev/s/g6cc2brtjvyvy
build-self-hosted-unsafe-jdk-8 https://ge.armeria.dev/s/srm7blrh7vxsa
build-self-hosted-unsafe-jdk-21-snapshot-blockhound https://ge.armeria.dev/s/dmprf27auy3uu
build-self-hosted-unsafe-jdk-17-min-java-17-coverage https://ge.armeria.dev/s/pika6wd377j72
build-self-hosted-unsafe-jdk-17-min-java-11 https://ge.armeria.dev/s/ggvlf5htdd4is
build-self-hosted-unsafe-jdk-17-leak https://ge.armeria.dev/s/owfs2jgguyeis
build-self-hosted-unsafe-jdk-11 https://ge.armeria.dev/s/o7wlth3fafvja
build-macos-12-jdk-21 https://ge.armeria.dev/s/avhbppiheu44g