Open seonWKim opened 3 weeks ago
Removed the [ISSUE-5741]
prefix in the commit messages.
Question) what do you think of just combining the two HealthCheckUpdateHandler and adding similar logic as HealthCheckService?
Looks better. I don't think we need to split them into different classes. 👍
Motivation:
Add support for degraded health.
Modifications:
HealthStatus
enum which can represent the health status of a serverhealthStatus()
method inHealthChecker
for fine-grained representation of server's statusdegradedResponse
which shows that the server's status is being degraded.I think adding new health check service which returns
HealthStatus
(instead of boolean) might be an alternate option. But because this PR is before any reviews, I've just implemented feature on top ofHealthCheckService
.Result:
Users can now receive notification for degraded server status like below
degraded
server status in addtion to healthy and unhealthy.