Open 0x1306e6d opened 1 week ago
Would it be a good idea for us to disable the escape option by default? Is there any risk of doing so? I think it's perhaps a good idea to escape the control characters though.
I agree that disabling by default has a risk. I think that keeping the default behavior and providing an option to control would be better so that users can take the risk.
I'm just trying to assess the risk. What risk would it have?
I see, I misunderstood the intention. I took a conservative approach: there might be a risk that I could not imagine. I couldn't imagine any risk.
Hello,
When using
LoggingService
with a gRPC service, an escaped content is logged when non-ASCII string is included in its message:I guess that this is the default behavior of protobuf-java's
toString()
. There's an option not to escape, so I could address by addingcontentSanitizer
to use the customTextFormat
only when the content type is protobufMessage
:For gRPC (Thrift also I guess),
Logging{Client|Service}
simply callstoString()
of aCompletableRpcResponse
and there's a weak support for handling its content for logging. It'd be useful if we provide a way to handle the content.