line / armeria

Your go-to microservice framework for any situation, from the creator of Netty et al. You can build any type of microservice leveraging your favorite technologies, including gRPC, Thrift, Kotlin, Retrofit, Reactive Streams, Spring Boot and Dropwizard.
https://armeria.dev
Apache License 2.0
4.73k stars 899 forks source link

Fix JsonSchemaGenerator to handle StructInfo with same alias and name #5788

Closed JonathanSawyer closed 5 days ago

JonathanSawyer commented 6 days ago

Motivation:

Modifications:

Result:

CLAassistant commented 6 days ago

CLA assistant check
All committers have signed the CLA.

github-actions[bot] commented 6 days ago

๐Ÿ” Build Scanยฎ (commit: 1587303119e0bdf8dc826a538b90c25178d508cd)

Job name Status Build Scanยฎ
build-windows-latest-jdk-21 โœ… https://ge.armeria.dev/s/qzpfop5luazps
build-self-hosted-unsafe-jdk-8 โœ… https://ge.armeria.dev/s/hhxwtegbr6qog
build-self-hosted-unsafe-jdk-21-snapshot-blockhound โœ… https://ge.armeria.dev/s/vz7yi74ponhsg
build-self-hosted-unsafe-jdk-17-min-java-17-coverage โœ… https://ge.armeria.dev/s/b2ulfgvfrd7es
build-self-hosted-unsafe-jdk-17-min-java-11 โœ… https://ge.armeria.dev/s/l3qu3btsl3rui
build-self-hosted-unsafe-jdk-17-leak โœ… https://ge.armeria.dev/s/uuvn7se5r23xi
build-self-hosted-unsafe-jdk-11 โœ… https://ge.armeria.dev/s/2hfoja7st3nno
build-macos-12-jdk-21 โœ… https://ge.armeria.dev/s/2ubudiudyehru
JonathanSawyer commented 6 days ago

@jrhee17 I was wondering whether this could be added to the 1.29.1 milestone?

trustin commented 5 days ago

Sorry I'm late and thanks for the fix, @JonathanSawyer! ๐Ÿ™‡

JonathanSawyer commented 5 days ago

Tested and working ๐Ÿ™‡