search

line / armeria

Your go-to microservice framework for any situation, from the creator of Netty et al. You can build any type of microservice leveraging your favorite technologies, including gRPC, Thrift, Kotlin, Retrofit, Reactive Streams, Spring Boot and Dropwizard.
https://armeria.dev
Apache License 2.0
4.83k stars 922 forks source link

Fix flaky `ServerMetrics` tests #5812

Closed jrhee17 closed 4 months ago

jrhee17 commented 4 months ago

Motivation:

The above flaky tests are failing relatively often: https://ge.armeria.dev/scans/tests?search.timeZoneId=Asia%2FSeoul&tests.container=com.linecorp.armeria.server.ServerMetricsTest#

Cancelling the request doesn't guarantee that the server-side request is closed immediately.

Modifications:

Result:

github-actions[bot] commented 4 months ago

🔍 Build Scan® (commit: 3ff2ff54bbac1c3600c9f8b8e8ab4ae57ec082fa)

Job name Status Build Scan®
build-windows-latest-jdk-21 ✅ https://ge.armeria.dev/s/amxqpgx7igjqq
build-self-hosted-unsafe-jdk-8 ✅ https://ge.armeria.dev/s/lujihy3dwjcbe
build-self-hosted-unsafe-jdk-21-snapshot-blockhound ✅ https://ge.armeria.dev/s/2n2igsqxpxk4s
build-self-hosted-unsafe-jdk-17-min-java-17-coverage ✅ https://ge.armeria.dev/s/tmwjw3w7ge644
build-self-hosted-unsafe-jdk-17-min-java-11 ✅ https://ge.armeria.dev/s/vwzdvm6vqstkq
build-self-hosted-unsafe-jdk-17-leak ❌ (failure) https://ge.armeria.dev/s/omcgmcmr4e7si
build-self-hosted-unsafe-jdk-11 ✅ https://ge.armeria.dev/s/ka56utoofbcrm
build-macos-12-jdk-21 ✅ https://ge.armeria.dev/s/x2zk4snffmre6