search

line / armeria

Your go-to microservice framework for any situation, from the creator of Netty et al. You can build any type of microservice leveraging your favorite technologies, including gRPC, Thrift, Kotlin, Retrofit, Reactive Streams, Spring Boot and Dropwizard.
https://armeria.dev
Apache License 2.0
4.83k stars 919 forks source link

Allow customizing the title of the documentation service #5900

Open ikhoon opened 1 month ago

ikhoon commented 1 month ago

The title of the documentation service is hard-coded to Armeria documentation service <version> https://github.com/line/armeria/blob/e0192ccbaa01f9c6f03849d4879507d93dc17aa8/docs-client/src/containers/App/index.tsx#L608-L611

Some users may want to override the title to easily distinguish a server from a different phase or role.

DocService
  .builder()
  .webAppTitle("Messaging (Alpha)")
  ...
  .build()

The specified web app title could be appended to the default title.

Armeria documentation service 1.30.1 - Messaging (Alpha)
dipeshsingh253 commented 1 month ago

Hi @ikhoon , I would like to contribute to this issue. Can you please assign it to me??

ikhoon commented 3 weeks ago

I've assigned https://github.com/line/armeria/issues/5219 to you. Do you want to resolve both of them at once?

dipeshsingh253 commented 3 weeks ago

Yeah, I can do that. This seems a good first issue as well.