line / centraldogma-python

Python client library for Central Dogma

https://line.github.io/centraldogma-python/

Apache License 2.0

19 stars 9 forks source link

Ready to publish #31

Closed hexoul closed 2 years ago

hexoul commented 2 years ago

Motivation

Modifications

Add publish workflow.
misc.
- Rename existing workflow to test.
- Add 3.10 testing environment.
- Revise README and setup.py.

Result

After creating release, we will get published centraldogma package!

codecov-commenter commented 2 years ago

Codecov Report

Merging #31 (c6ff1b2) into main (684de5a) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #31   +/-   ##
=======================================
  Coverage   93.38%   93.38%           
=======================================
  Files          21       21           
  Lines         650      650           
=======================================
  Hits          607      607           
  Misses         43       43

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 684de5a...c6ff1b2. Read the comment docs.

ikhoon commented 2 years ago

By the way, did I set the initial milestone to 0.1.1? 🤔 Which is a better version for the initial version between 0.1.1 and 0.1.0? https://stackoverflow.com/questions/52236193/what-is-the-proper-first-version-0-1-0-or-0-0-1-or-anything-else

minwoox commented 2 years ago

Which is a better version for the initial version between 0.1.1 and 0.1.0?

Let's start with 0.1.0. :wink:

hexoul commented 2 years ago

I set to 0.1.1 because I made a mistake in testing a publishing at local 😅. I uploaded the version 0.1.0 and delete the package. So it is not revealed now.

Unfortunately, PyPi does not allow to reuse versions. When we try to publish with 0.1.0, it will fail.