Closed jrhee17 closed 1 month ago
Attention: Patch coverage is 60.00000%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 71.58%. Comparing base (
f810f16
) to head (543e762
). Report is 6 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
...gma/client/armeria/xds/XdsCentralDogmaBuilder.java | 60.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Motivation
While verifying whether zone-aware routing works correctly, I found that the
serviceCluster
options wasn't being respected.ref: https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/bootstrap/v3/bootstrap.proto#envoy-v3-api-field-config-bootstrap-v3-clustermanager-local-cluster-name
I'm not sure why I thought using
serviceCluster
was a good idea, but it is probably a better idea to acceptlocalClusterName
if we want to take advantage of zone-aware routingModifications
serviceCluster
tolocalClusterName
localClusterName
toBootstrap#clusterManager#localClusterName
Result
XdsCentralDogmaBuilder
supports zone-aware routing correctly