line / centraldogma

Highly-available version-controlled service configuration repository based on Git, ZooKeeper and HTTP/2
https://line.github.io/centraldogma/
Apache License 2.0
601 stars 117 forks source link

May I pass APP_HOME as arguments? #258

Closed nobe0716 closed 6 years ago

nobe0716 commented 6 years ago

Hello,

I recently consider centraldogma as alternative for zookeeper. And I meet a problem to apply it on my server.

Since centraldogma uses APP_HOME as its env variables, It made a conflict with my pre-exist env variables.

I have used "~/apps" as APP_HOME already, so centraldogma misread env and could not start correctly with JSVC errors.

I wish for centraldogma to have more concrete name of env variable such as CD_APP_HOME or to support arguments for APP_HOME

Thanks

minwoox commented 6 years ago

Hello! @nobe0716 Thank you for your interest about our project. We are going to figure out the better way to handle this situation, but could you just unset APP_HOME or set as empty string before you start the server?

nobe0716 commented 6 years ago

@minwoox I had already done, and set up CD, but it can occur conflict with pre-exist applications

thanks you for your suggestion.

minwoox commented 6 years ago

@nobe0716 Glad to hear that you set up CD! Please let us know if there is any problem while you are using it.