search

line / create-liff-app

Start developing LIFF application with a simple CLI command.
https://developers.line.biz/en/docs/liff/
Apache License 2.0
63 stars 7 forks source link

Hardcoded dependencies become outdated #11

Closed BWsix closed 2 years ago

BWsix commented 2 years ago

Hi, I really enjoy using this package to quickly generate liff projects, but I found some issues with outdated dependencies.

Currently, dependencies are hardcoded into package.jsons and some have already become outdated. I looked into how create-next-app handles this issue and found that they install all the dependencies using spawn in runtime to get the latest versions of dependencies. Below is a demonstration of how they do it: (source code)

const dependencies = ['react', 'react-dom', 'next'];
spawn(packageManager, dependencies);

You'll gain two benefits from implementing this method:

  1. Manual updates of the liff package are no longer needed
  2. Up-to-date dependencies

If you think this is a good idea, just let me know and I could try to make a PR for this. Btw, all the linebreaks in this project are CRLF, not LF as defined in .eslint.js. And there is no configuration file for installed dev-dependency prettier.

so99ynoodles commented 2 years ago

@BWsix First of all, thank you for your continuous contribution! 🙇‍♂️ Let me talk with the LIFF team about this issue.

BWsix commented 2 years ago

I see!

so99ynoodles commented 2 years ago

@BWsix We discussed and would like you to create the PR for this issue! There are some concerns like the stability of the dependencies or build settings of the templates but we would like to discuss them in the PR review in detail.

BWsix commented 2 years ago

@so99ynoodles Sure! I'll work on it asap.