line / create-liff-app

Start developing LIFF application with a simple CLI command.
https://developers.line.biz/en/docs/liff/
Apache License 2.0
63 stars 7 forks source link

refactor: ensures dependencies are up-to-date #15

Closed BWsix closed 2 years ago

BWsix commented 2 years ago

Fixes https://github.com/line/create-liff-app/issues/11

This PR changes how create-liff-app install dependencies, ensuring that all dependencies used in generated projects are up-to-date. I'm not sure if this is fixing the issue or making it even worse, any feedback would be great🙏

Changes:

Problems that need to be discussed:

Notes:

BWsix commented 2 years ago

Since Nuxtjs and Nextjs provide their own create-app feature, how do you think using them inside create-liff-app and replacing the result with our templates?

I did some changes (https://github.com/line/create-liff-app/pull/15/commits/c406a40b82db1ffac6a30553329bc0f6d239ce8f) and create-liff-app will now generate nextjs & nuxtjs projects using their create-app feature. Does this look ok to you?

Changes:

nuxtjs projects generated by the current version(1.0.4) of create-liff-app do not work as expected, as it always throws this error: Error: liffId is necessary for liff.init(). I do not know how to fix that.

Also, as I mentioned in the original PR, nuxtjs app does not work as expected. Therefore, I am unsure if the above change will break anything. Please remember to double-check the changes!

BWsix commented 2 years ago

let us set up CI to automatically test and lint before merging

Please help me out on this one, as I do not know how😅

BWsix commented 2 years ago

Thank you and your team for the time and effort you spent reviewing this PR👍

so99ynoodles commented 2 years ago

Maybe we should fix the test since the local test fails. yarn test

so99ynoodles commented 2 years ago

Merging this! 🎉