Use TopicPartition.topic for metrics

line / decaton

High throughput asynchronous task processing on Apache Kafka

Apache License 2.0

336 stars 51 forks source link

Closed tadashiya closed 6 months ago

tadashiya commented 6 months ago

I noticed that the metrics always use scope.topic() after #224.
I think it's useful to keep metrics separate between normal topic and retry topic. This change will use scope.topicPartition().topic() to use the retry topic name for metrics when handling the retry topic.

CLAassistant commented 6 months ago

All committers have signed the CLA.

kawamuray commented 6 months ago

This has been released as 8.0.1. Thanks for your contribution :) https://github.com/line/decaton/releases/tag/v8.0.1

tadashiya commented 6 months ago

OK, thanks for your help.