search

line / flutter_line_sdk

A Flutter plugin that lets developers access LINE's native SDKs in Flutter apps with Dart.
https://developers.line.biz/
Apache License 2.0
213 stars 43 forks source link

Sending the result twice causes an error #18

Closed najeira closed 4 years ago

najeira commented 4 years ago

What did you do?

Not reproducible, but seems to send error twice under some conditions. In rare cases, errors are measured in our app crash records.

What did you expect?

https://github.com/line/flutter_line_sdk/blob/master/android/src/main/kotlin/com/linecorp/flutter_line_sdk/LineSdkWrapper.kt#L119

Here, since the method has not returned, the error will be sent again after this. loginResult = null and return true seem necessary after the line.

onevcat commented 4 years ago

Should be fixed in #20