line / flutter_line_sdk

A Flutter plugin that lets developers access LINE's native SDKs in Flutter apps with Dart.
https://developers.line.biz/
Apache License 2.0
213 stars 42 forks source link

The pubspec.lock should not be contained in this repo #81

Closed onevcat closed 1 year ago

onevcat commented 1 year ago

Is it a security issue?

No.

What did you do?

Please describe what you did before you encounter the issue.

Clone the repo and build the package.

What did you expect?

Please describe what you did expect to happen.

The package should build against with the lasted dependencies.

What happened actually?

Please describe what happened actually.

It reads the pubspec.lock file and keeps using old dependencies and environments.

According to the guideline of pub.dev, the lock file should not be contained and submitted to CVS.

For regular packages, don’t commit the pubspec.lock file. Regenerating the pubspec.lock file lets you test your package against the latest compatible versions of its dependencies.

Ref: https://dart.dev/guides/libraries/private-files

Your environment?

Some information of the environment in which the issue happened. Package version, Xcode version, iOS version, etc.

N/A

Sample project

It would be appreciated if you can provide a link to or update a sample project that we can download and reproduce the issue.

N/A

onevcat commented 1 year ago

Done in #82