search

line / jnotebook_reader

:black_joker: An awesome viewer to browse and render Jupyter Notebooks from local, Amazon S3, Google Cloud Storage or MinIO
Apache License 2.0
103 stars 17 forks source link

Improvement suggestion for listing S3 objects #12

Closed withsmilo closed 3 years ago

withsmilo commented 3 years ago

@mars-martin-line I've found a need for improvement on the jnotebook-reader. If there are more than 1000 files or directories in one directory, jnotebook-reader shows only 1000 files. It seems we need the S3 Paginator. Please refer to https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/s3.html#S3.Paginator.ListObjectsV2.

mars-martin-line commented 3 years ago

Done

withsmilo commented 3 years ago

The PR contained in v1.0.2 resolved this issue.