search

line / jnotebook_reader

:black_joker: An awesome viewer to browse and render Jupyter Notebooks from local, Amazon S3, Google Cloud Storage or MinIO
Apache License 2.0
103 stars 17 forks source link

Fix support for buckets specified as dicts (#14) #15

Closed ricecooker closed 2 years ago

CLAassistant commented 2 years ago

CLA assistant check
All committers have signed the CLA.

hechangqin commented 2 years ago

@ricecooker Thank you for your contribution. But the following code should also have the problem you mentioned, could you modify it in this pr at the same time? https://github.com/line/jnotebook_reader/blob/b72d3e71560c724fb22d21c62413b205f00cc786/renderer/s3/s3.py#L35