line / kotlin-jdsl

Kotlin library that makes it easy to build and execute queries without generated metamodel

Apache License 2.0

651 stars 85 forks source link

Motivation

If in condition is used alone in the where clause and the compare values is empty, a malformed query is generated.

Modifications

If compare values is empty, it renders 0 = 1 instead of nothing.

Commit Convention Rule

Please commit your modification based by conventional commit:

Commit type	Description
feat	New Feature
fix	Fix bug
docs	Documentation only changed
ci	Change CI configuration
refactor	Not a bug fix or add feature, just refactoring code
test	Add Test case or fix wrong test case
style	Only change the code style(ex. white-space, formatting)
chore	It refers to minor tasks such as library version upgrade, typo correction, etc.

If you want to add some more commit type please describe it on the Pull Request

Result

If in condition is used alone in the where clause and the compare values is empty, the malformed query is no longer generated.
For those who didn't use the in condition alone in the where clause, their query might not work as expected, as it would have been the same as if 1 = 1 was printed.

Closes

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.01%. Comparing base (a33bf96) to head (25ce71b).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #704 +/- ## ======================================= Coverage 92.01% 92.01% ======================================= Files 335 335 Lines 3417 3419 +2 Branches 203 203 ======================================= + Hits 3144 3146 +2 Misses 213 213 Partials 60 60 ```