line / kotlin-jdsl

Kotlin library that makes it easy to build and execute queries without generated metamodel
https://kotlin-jdsl.gitbook.io/docs/
Apache License 2.0
651 stars 85 forks source link

modify entity, join serializers to allow specify entity() as the on clause predicate. #729

Closed sjnqkqh closed 4 days ago

sjnqkqh commented 6 days ago

Motivation

Modifications

Commit Convention Rule

Commit type Description
feat New Feature
fix Fix bug
docs Documentation only changed
ci Change CI configuration
refactor Not a bug fix or add feature, just refactoring code
test Add Test case or fix wrong test case
style Only change the code style(ex. white-space, formatting)
chore It refers to minor tasks such as library version upgrade, typo correction, etc.

Result

Closes

CLAassistant commented 6 days ago

CLA assistant check
All committers have signed the CLA.

shouwn commented 5 days ago

Please change the base branch to main as this change is to fix a bug.

codecov-commenter commented 5 days ago

Codecov Report

Attention: Patch coverage is 95.12195% with 2 lines in your changes missing coverage. Please review.

Project coverage is 91.96%. Comparing base (9a6be26) to head (ce02dd2).

Files Patch % Lines
...linjdsl/render/jpql/serializer/JpqlRenderClause.kt 75.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #729 +/- ## ======================================= Coverage 91.96% 91.96% ======================================= Files 335 335 Lines 3423 3448 +25 Branches 203 204 +1 ======================================= + Hits 3148 3171 +23 - Misses 213 215 +2 Partials 62 62 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sjnqkqh commented 5 days ago

Please change the base branch to main as this change is to fix a bug.

shouwn commented 4 days ago

II've changed the base branch from develop to main, but the branch I forked for the fix is line/kotlin-jdsl:develop, in which case would it be better to reference the main branch of line/kotlin-jdsl to do the work and publish the PR?

You can use cherry-pick. You can migrate your work by creating a new branch from the main branch and cherry-picking the commits you're currently working on to the new branch.