search

line / line-bot-sdk-python

LINE Messaging API SDK for Python
https://pypi.python.org/pypi/line-bot-sdk
Apache License 2.0
1.91k stars 971 forks source link

ChannelAccessToken client doesn't have to require channel access token #557

Closed Yang-33 closed 10 months ago

Yang-33 commented 10 months ago

(I should replace mustache with pebble...)

tokuhirom commented 10 months ago

ah, no. i misunderstood. module-attach.yml only contains the endpoint of the Attach by operation of the module channel provider.

tokuhirom commented 10 months ago

Maybe something like this is even better.

        self.default_headers['Authorization'] = '{% if isBasicBearer %}Basic{% else %}Bearer{% endif %} ' + configuration.access_token
Yang-33 commented 10 months ago

Thank you for your comment! As you said, I forgot module-attach uses Basic Authentication. I fixed this in https://github.com/line/line-bot-sdk-python/pull/557/files/30f803f7e0d89cb623b0453dd7778e55eb8cc54f..b6cc1aac82143e761c3c03f2b60435044a51a28a. PTAL again!