search

line / line-fido2-server

FIDO2(WebAuthn) server officially certified by FIDO Alliance and Relying Party examples.
Apache License 2.0
528 stars 98 forks source link

Fix: Correct API endpoint mismatch in CredentialController #49

Closed cinari4 closed 1 year ago

cinari4 commented 1 year ago

What is this PR for?

Fixing API Endpoint Mismatch Issue in CredentialController

Overview or reasons

I have identified an issue in the CredentialController on the server. Currently, the endpoint for receiving requests is set as /fido2/credentials/{id}, but I noticed that when constructing the API address on the rpserver, it is being called as /fido2/credentials{id}. As a result, the credentials API cannot be successfully invoked.

Tasks

When calling the credentials API, you need to configure the address of that API in rpserver, pathSegment function when calling the credentials API.

Result

Now able to call the server's credential/{id} api from rpserver as normal.

CLAassistant commented 1 year ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

mong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

cinari4 commented 1 year ago

Close this PR because it was requested incorrectly.