line / line-fido2-server

FIDO2(WebAuthn) server officially certified by FIDO Alliance and Relying Party examples.

Apache License 2.0

528 stars 98 forks source link

UserKeyServiceImpl convert function does not support EdDSA Algorithm #5

Closed gmulhearn closed 3 years ago

gmulhearn commented 3 years ago

What is this PR for?

See Issue #4

Overview or reasons

Please see Issue #4

Tasks

added a case for the EdDSA algorithm.

Result

I have tested this with a custom authenticator (i.e. one that works on local servers / non https servers) forced to use EdDSA, and confirmed that it works for EdDSA keys.

CLAassistant commented 3 years ago

All committers have signed the CLA.

kj84park commented 3 years ago

LGTM! Thank you for your contribution!

kj84park commented 3 years ago

For merging, could you sign the CLA?

gmulhearn commented 3 years ago

hey there, thanks for your review. I have signed the CLA thru the website the github bot links, but the github bot doesn't seem to recognise/update? When I click on the link now I get "You have agreed to the CLA for line/line-fido2-server". Is there anything I can do to update the bot?

gmulhearn commented 3 years ago

ah whoops! i'd made a commit from another account and had to sign with both. all fixed now