search

line / line-sdk-android

LINE SDK for Android lets you integrate LINE into your Android app to create a more engaging experience for your users.
https://developers.line.biz/en/docs/android-sdk/
Apache License 2.0
133 stars 45 forks source link

Text_highligh Specifies the same color ID #129

Open BoredLen opened 1 year ago

BoredLen commented 1 year ago

Is it a security issue?

Not

What did you do?

The Colors directory in the SDK has many color values that are too generic, such as text_highlight, background, etc. This time our app has the same color ID as the Line SDK, which causes the LINE SDK colors to overwrite our app. We solved this problem in other ways

What did you expect?

I hope the Line SDK can consider this aspect of naming, such as adding a prefix or a relatively unique ID

What happened actually?

The same color ID causes the line color to cover our app our app color name="text_highlight">@color/ck_orange line app color name="text_highlight">#07bf3f

plateaukao commented 1 year ago

Hi, @BoredLen Thank you for the suggestion. We will enhance this part in next release.