line / line-sdk-android

LINE SDK for Android lets you integrate LINE into your Android app to create a more engaging experience for your users.
https://developers.line.biz/en/docs/android-sdk/
Apache License 2.0
133 stars 45 forks source link

Remove allowBackup in application tag #131

Open giangpham96 opened 1 year ago

giangpham96 commented 1 year ago

Is it a security issue?

no

What did you do?

Consume Line SDK 5.4.1 to 5.8.0. They declare allowBackup as false in AndroidManifest.

What did you expect?

I believe the consumer should declare this, not the library. If an application have allow backup set to true, they need to use tools:replace tag to override the value from this library.

This is somehow acceptable.

However, if there is another library which set the flag to true, the overriding of the consumer result in an error during lint. For example, here is my stacktrace

Attribute application@allowBackup value=(false) from [com.linecorp.linesdk:linesdk:5.8.0] AndroidManifest.xml:22:9-36
        is also present at <...> AndroidManifest.xml:20:9-35 value=(true).

What happened actually?

The library has allowBackup declaration