line / line-sdk-android

LINE SDK for Android lets you integrate LINE into your Android app to create a more engaging experience for your users.
https://developers.line.biz/en/docs/android-sdk/
Apache License 2.0
133 stars 45 forks source link

Is Picasso absolutely needed for Line SDK? #163

Open halizton opened 5 months ago

halizton commented 5 months ago

This is more as a question or feature request instead of an issue.

What did you do?

We integrate Line SDK for login purpose and realized Line SDK bringing in the entire Picasso image loading library. We use glide to load images in our app. The introduction of Picasso SDK makes our final app bigger.

What did you expect?

While Line SDK is a light SDK for login purpose, it is surprising that it brings in Picasso. We searched Line SDK code base and realized there are only 2 use cases where Picasso is used to load typical images into ImageView with a place holder. So we are wondering if the Picasso SDK can be removed and Line SDK can use the typical BitmapFactory to load those 2 images.

https://github.com/search?q=repo%3Aline%2Fline-sdk-android+Picasso.get%28%29&type=code

What do you think and I can help making the change if you prefer :)