search

line / line-sdk-starter-android-v2

A starter application that demonstrates how to use LINE SDK V2 for Android.
MIT License
35 stars 27 forks source link

getLoginIntent()後に「ログインしました」というToastを非表示にできますか #19

Open h-sol719 opened 7 years ago

h-sol719 commented 7 years ago

getLoginIntent()後に「ログインしました」というToastが勝手に出ますが、これを非表示にする方法はないですか？ ログインSDKなので、ログイン処理のみ行えば良いと思います。UI部分まで含まれていて、しかもそれが変更できない仕様は非常によくないです。Facebook Login SDKを参考に修正してください。 あとドキュメントがひどい(簡略すぎる)ので、修正してほしいです。

getLoginIntent() 후에 로그인했다는 토스트가 멋대로 나오는데, 이걸 표시안하는 방법이 있을까요? 갠적으로 로그인SDK는 로그인 처리만 할 수 있으면 된다고 생각합니다. 로그인SDK가 UI부분까지 포함되어 있는데다가 그 UI가 변경불가능한 사양은 매우 안좋습니다. Facebook Login SDK를 참고해서 설계를 변경해주셨으면 합니다. 그리고 개발자용 도큐멘트가 너무 대충입니다. 라인이라는 플랫폼이 세계적인 플랫폼인데 이래서 되겠습니까.

mrmaakun commented 7 years ago

Hi @h-sol719

Correct me if I'm wrong, but I believe the toast messages are coming from the sample application and not the SDK itself. When you use the SDK in your own application, you may choose to do whatever you want when the login succeeds or fails.

In regards to your comment about the documentation, the README is intended to be a simple explanation of running the sample application and nothing more. The detailed documentation for the Android SDK can be found here: Android SDK Overview. If you feel that this documentation is still lacking, please feel free to leave feedback about it and we will use it to help improve our documentation.

h-sol719 commented 7 years ago

@mrmaakun Thank you for the reply.

the toast messages are coming from the sample application and not the SDK itself

I think you are not correct, and I'm wrong, too. Maybe the toast message is coming from Line android application. The toast is shown when you log in only via the Line app (app-to-app login). It is not happening when you use the app-to-browser login. Also the message of toast has a multilingual function. If your android phone's language setting is set on English, the message of toast will be "Login successful!". (setting on Japanese, it will be "ログインしました") If you don't mind, could you check again?

I do not want to the toast came show up, because my app register some informations into a server, after the Line login, and it takes a few seconds. So, login-successful toast is unnecessary for me.

HirotoIchinose commented 6 years ago

Saw the same bug in our app. Please fix this.

Alexander-Foster commented 5 years ago

I also same bug. plz fix it

leyvien commented 5 years ago

me too, plz fix it

niusounds commented 2 years ago

me too, still happens in SDK v5.7.0.