search

line / line-sdk-unity

Provides a modern way of implementing LINE APIs in Unity games, for iOS and Android.
https://developers.line.biz/
Apache License 2.0
117 stars 24 forks source link

fix: upgrade android sdk to 5.8.1 on Maven center instead of jcenter #52

Closed tsairene closed 1 year ago

tsairene commented 1 year ago

Summary

Address issue #51

Due to deprecation of jcenter, update Android library repo from jcenter to mavenCentral.

Since there's no line-sdk-android v5.1.1, it's also updated to use latest one v5.8.1 instead.

Verification

Build And Run on Pixel 6 Pro

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

onevcat commented 1 year ago

@tsairene Thanks!

Maybe a stupid question from an Android noob, should we make any change in these lines?

https://github.com/line/line-sdk-unity/pull/52/files#diff-8bc82e19b67c762db2a66040fc7dbaeb007451fcd6504984dbe0a877111bb612L17-L22

tsairene commented 1 year ago

@onevcat Thanks for reminding! To avoid misunderstanding, I remove jcenter repo and assign mavenCentral instead.

onevcat commented 1 year ago

Nice! LGTM.

Thanks for the fixing.