search

line / promgen

Promgen is a configuration file generator for Prometheus
https://line.github.io/promgen/
MIT License
1.06k stars 150 forks source link

Add build pipeline for Primevue #456

Closed bai1024 closed 4 months ago

bai1024 commented 10 months ago

This PR shows the build pipeline for Primevue Before try to use the new components, we need to import them first in promgen-gen/main.js Then run make primevue command. After the new file is generated under static/promgen. You can start to use the new components!

CLAassistant commented 10 months ago

CLA assistant check
All committers have signed the CLA.

kfdm commented 10 months ago

I'm still needing to find time to review this, but remembered we will also need to ensure this still works with a docker container. In that case, we likely want a muti build image that builds the javascript in it's own image and then copies it over to the release image.

vincent-olivert-riera commented 10 months ago

I'm still needing to find time to review this, but remembered we will also need to ensure this still works with a docker container. In that case, we likely want a muti build image that builds the javascript in it's own image and then copies it over to the release image.

@bai1024 , I have created a pull request for the necessary changes to the Makefile and the Dockerfile. After you merge my commits into your branch, you can squash them all together and update this PR.

Also, I noticed you tried to remove the generated files from this PR with this commit: f70e159. However, I think during the rebase you did after that, the commit was removed and the generated files are back on this PR. Please check it out.

kfdm commented 4 months ago

Internally we discussed handling some of this a different way, so will close this PR for now.