search

line21c / google-api-dotnet-client

Automatically exported from code.google.com/p/google-api-dotnet-client
Apache License 2.0
0 stars 0 forks source link

MethodValidator.ValidateParameter should validate enums #66

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Discovery provides enum values for some parameters, these should be validated 
if present.

See GoogleApis/Apis/Requests/MethodValidator.cs

Original issue reported on code.google.com by davidwat...@google.com on 16 Jun 2011 at 11:00

GoogleCodeExporter commented 9 years ago 
I would like to get rid of the Discovery requirement when executing Requests at 
some point, so I would be inclined to not enhance it further it this point. We 
should do all type checking in the generated methods instead. 

If we do not have the resources to do the refactoring, we could also just cache 
the discovery document within the client itself for the moment.

If we manage to remove the discovery dependency in the core library, we might 
be able to use the code generated discovery in the future.

Original comment by mlin...@google.com on 16 Jun 2011 at 2:03

GoogleCodeExporter commented 9 years ago 
The original design (before I got on-board) was to strongly support the direct 
use of the api and generated api was second class. I personally agree with your 
statement that the strongest support should be for the generated code. We 
should get wider buy-in for that sentiment before making any changes the make 
the direct API less powerful. 

If the core Api is calling discovery alot it should switch the default to using 
CachedWebDiscoveryDevice with a short time out say 1 hour.

Original comment by davidwat...@google.com on 16 Jun 2011 at 2:24

GoogleCodeExporter commented 9 years ago

Original comment by mlin...@google.com on 23 Jun 2011 at 2:17

GoogleCodeExporter commented 9 years ago

Original comment by mlin...@google.com on 1 Jul 2011 at 6:18