Crash when inputbuf is out of space

line72 / helplightning-libpurple

Help Lightning plugin for libpurple

GNU General Public License v3.0

0 stars 0 forks source link

Crash when inputbuf is out of space #9

Closed line72 closed 1 year ago

line72 commented 1 year ago

Our inputbuf is way too small. We can get into a situation, where we don't have enough space to hold a whole CMF chunk, and therefore can't decode anymore. We end up wrapping around our unsigned remaining length and crashing.

The fix here is two fold:

Increase the inputbuf to 32768. This is bigger than any CFM chunk
Fix the wrap around so we don't crash, just in case!

line72 commented 1 year ago

Merged in master in ef5b9f4ba7b123a2f4ee38e5764d43c1615bd293