lineageos4microg / android_prebuilts_prebuiltapks

57 stars 103 forks source link

Include IzzyOnDroid repo with additional_repos.xml? #35

Closed IzzySoft closed 3 years ago

IzzySoft commented 3 years ago

Not sure which ROMs are using this repo, but it might be useful to include my repo with additional_repos.xml. As this "stinks" a little like ego-promo :mask:, let me give some background:

No bad feelings if you say "no", it's just a suggestion. After all you even include tools to access Google Play :rofl: So my suggestion is to include my repo but have it turned off by default, so users can easily enable it if they want to. There's no "archive", just the "main repo".

You might wish to do the same for the Kali Nethunter repo, btw, for another ~50 apps.

ghost commented 3 years ago

I think the sole purpose of this project should be to include those MicroG APKs that need signature spoofing. All other modifications should be up to the LineageOS developers. Keep it simple.

famo commented 3 years ago

I think it is a bad idea to add random repos by default in the installation, because this is a matter of trust.

If there is a toggle in the welcome dialog, by which user could enable additional repos (opt-in), than I'm all for it. But please not by default behind the users back.

IzzySoft commented 3 years ago

@famo that's exactly what I meant. Quote (with emphasis):

include my repo but have it turned off by default, so users can easily enable it if they want to.

Full ack to this being a matter of trust – and my repo simply does not deserve that level of trust to come "enabled by default" – despite all the precautions I take to make it as safe as possible. I think it's pretty good, but the decision whether it's "good enough" should be left to the user. No bad feelings if someone doesn't feel it "good enough" (except if the same person thinks Play Store deserves the trust, as that I'd feel schizophrenic :wink:).

Btw, I think some other repos fall into the very same category (deserving to be pre-configured but off by default), like Bromite, CalyxOS, Droidware (ungoogled Chromium), Firefox unofficial (Firefox, Kiwi, Signal, Wire …).

All other modifications should be up to the LineageOS developers.

Does "plain LineageOS" even include F-Droid by default? If not, that argument doesn't even fit the case.

my repo currently holds close to 600 apps

Just 3 months later, and the number must be corrected: it's "close to 700" meanwhile (681 at the time of writing this) – raising the number of apps available to over 4k (4042 with F-Droid + microG + IoD; F-Droid itself currently has 3347 apps, so it's a plus of 20%).

bananer commented 3 years ago

While I appreciate the efforts of people running F-Droid repos, I don't think they should be added to the lineageos4microg ROM by default.

Including F-Droid with the microG repos makes sense to keep the included microG packages up to date.

Including other repos would be free advertisement or scope creep in the best case and a whole lot of new issues in the worst case. Just one example: CalyxOS contains a com.android.webview package, certainly with a different signature then the one included in official builds in this rom.

spolack commented 3 years ago

Thank you @bananer

IzzySoft commented 3 years ago

Thanks for considering at least. I understand the decision – though I hoped for a different outcome :wink: