search

lineageos4microg / android_prebuilts_prebuiltapks

57 stars 103 forks source link

GmsCore: don't overwrite LOCAL_REQUIRED_MODULES #48

Closed bananer closed 3 years ago

bananer commented 3 years ago

This should fix #47 while still preventing battery optimizations on GmsCore ( #44 )

Currently running my own build to see if it works as expected.

bananer commented 3 years ago

Works for me. Upgraded from a pre #44 build and did not lose permissions.

ghost commented 3 years ago

Heh, silly mistake.

For the record, this did not cause any issues on my cm-14.1 builds, so this went unnoticed.

I noticed a while ago that you could (should) just include everything onto one line, actually, but I was too lazy to change it because it appeared to work fine, so I (wrongly) assumed both ways were equivalent. Oops!