search

lineageos4microg / docker-lineage-cicd

Docker microservice for LineageOS Continuous Integration and Continous Deployment
https://hub.docker.com/r/lineageos4microg/docker-lineage-cicd
GNU General Public License v3.0
480 stars 189 forks source link

LOS Signature spoofing changes don't work for `user` builds #614

Closed petefoth closed 2 months ago

petefoth commented 2 months ago

The original description of #607 conflates two issues

  1. Our signature spoofing patches fail to build because of the missing @FlaggedAPI annotation for the new APIs
  2. The upstream changes which allow signature spoofing only work for 'debuggablebuilds (e.g.userdebug) and not foruser` builds.

IMO the two issue are separate, and should be fixed separately. 1: is addressed in #607

This issue is to track 2.

The changes in the nns-v21-spoofing-patches branch and PR #612 fixes this issue but doesn't fix 1; it removes the patches rather than fixing them.

Originally posted by @petefoth in https://github.com/lineageos4microg/docker-lineage-cicd/issues/607#issuecomment-2070874499